<html>
<head><meta charset="utf-8"><title>LSP 3.15 · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html">LSP 3.15</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="179926330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179926330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Martin Asquino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179926330">(Nov 05 2019 at 12:23)</a>:</h4>
<p>Not directly related but given that rust-analyzer depends on the lsp-types crate I figured I'd share it here. I've opened a draft PR on lsp-types to add the missing types to support the new version of the specification: <a href="https://github.com/gluon-lang/lsp-types/pull/119" target="_blank" title="https://github.com/gluon-lang/lsp-types/pull/119">https://github.com/gluon-lang/lsp-types/pull/119</a></p>
<p>Still need to mark the newly deprecated fields as such, but I think it's pretty close to be done.</p>



<a name="179928803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179928803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Martin Asquino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179928803">(Nov 05 2019 at 12:57)</a>:</h4>
<p>Oops! Good catch on the missing serde skips <span class="user-mention" data-user-id="203366">@Jeremy Kolb</span>  <span aria-label="smiley" class="emoji emoji-1f603" role="img" title="smiley">:smiley:</span></p>



<a name="179929510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179929510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179929510">(Nov 05 2019 at 13:07)</a>:</h4>
<p>Yep! Left you some comments. Thanks for doing this.</p>



<a name="179958496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179958496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Martin Asquino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179958496">(Nov 05 2019 at 18:03)</a>:</h4>
<p>Updated the PR with fixes for most of your comments. I do have a doubt though: I'm not sure what you meant by <code>I don't see the new registration option stuff yet.</code>. Maybe I missed something in the change log? I can't see anything about new registration types.</p>
<p>Also, I renamed <code>WorkDoneProgressDone</code> to <code>WorkDoneProgressEnd</code>. I considered creating a new type to maintain the legacy one, but as the library specifically states that the types behind the <code>proposed</code> flag do not guarantee semver compatibility I figured we would be ok with just renaming it. This may be obviously revisited by the project maintainer, but wanted to get your opinion on this anyway</p>



<a name="179959860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179959860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179959860">(Nov 05 2019 at 18:17)</a>:</h4>
<p>Ah I meant the <code>WorkDoneProgressOptions</code></p>



<a name="179959879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179959879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179959879">(Nov 05 2019 at 18:17)</a>:</h4>
<p>yeah i wouldn't worry about maintaining backwards compatibility with <code>proposed</code> stufff</p>



<a name="179960024"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179960024" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Martin Asquino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179960024">(Nov 05 2019 at 18:19)</a>:</h4>
<p>ooh, yeah, I completely missed that. Searched for <code>@since 3.15.0</code> and that wasn't included <span aria-label="raised hand" class="emoji emoji-270b" role="img" title="raised hand">:raised_hand:</span> <span aria-label="pensive" class="emoji emoji-1f614" role="img" title="pensive">:pensive:</span></p>



<a name="179960374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179960374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179960374">(Nov 05 2019 at 18:22)</a>:</h4>
<p>Yeah it's easy to miss changes in the spec that's for sure</p>



<a name="179960419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179960419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Martin Asquino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179960419">(Nov 05 2019 at 18:23)</a>:</h4>
<p>oh, I found a bunch of proposed attributes that need dropping too. I'll try harder this time hehe</p>



<a name="179960666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/179960666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#179960666">(Nov 05 2019 at 18:25)</a>:</h4>
<p>You may be able to follow the model used in <a href="https://github.com/gluon-lang/lsp-types/pull/110" target="_blank" title="https://github.com/gluon-lang/lsp-types/pull/110">https://github.com/gluon-lang/lsp-types/pull/110</a> for the <code>WorkDoneProgressOptions</code> stuff (I haven't looked too closely).</p>



<a name="180157007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/180157007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Martin Asquino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#180157007">(Nov 07 2019 at 17:58)</a>:</h4>
<p>So I was looking at the WorkDoneProgressOptions thing now. There a bunch of types that now extend on those, what you are saying is that that should be represented as a <code>pub work_done_progress_option: Option&lt;WorkDoneProgressOption&gt;</code> attributed with <code>#[serde(flatten)]</code>, right?</p>



<a name="180158238"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/LSP%203.15/near/180158238" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/LSP.203.2E15.html#180158238">(Nov 07 2019 at 18:11)</a>:</h4>
<p>yeah I think that's the right approach</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>